From 034ebade0d5ef6957ce77983cbaea42d62561957 Mon Sep 17 00:00:00 2001 From: rootiest Date: Fri, 19 Jun 2026 01:56:58 -0400 Subject: [PATCH] feat(edit): stop forcing VISUAL to the terminal editor VISUAL was hardwired to $EDITOR (nvim), so 'edit --visual' would launch a terminal editor detached with no tty. Comment it out so --visual falls through to the GUI fallback chain, and let users set a real GUI editor via local.fish. Update the editor-variable docs to match. --- config.fish | 2 +- docs/fish-config.md | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config.fish b/config.fish index dd1a860..8234511 100644 --- a/config.fish +++ b/config.fish @@ -108,7 +108,7 @@ if type -q nvim else set -gx EDITOR (command -s vi) end -set -gx VISUAL $EDITOR +# set -gx VISUAL $EDITOR # <- Use local.fish to set your preferred GUI editor. set -gx SUDO_EDITOR $EDITOR # ──────────────────────────── GPG variables ───────────────────────────── diff --git a/docs/fish-config.md b/docs/fish-config.md index 215feb3..033f501 100644 --- a/docs/fish-config.md +++ b/docs/fish-config.md @@ -159,7 +159,8 @@ Tools that respect XDG are directed to these paths rather than polluting $HOME. ## Editor and Pager EDITOR nvim (falls back to vi if nvim is absent) - VISUAL same as EDITOR + VISUAL unset by default; set a GUI editor via local.fish (the edit + function falls back to a GUI chain when VISUAL is empty) SUDO_EDITOR same as EDITOR PAGER ov (falls back to less)