From 0b4ab30b40675501b598480c709db1ba15a97bc7 Mon Sep 17 00:00:00 2001
From: Rootiest <chris@rootiest.com>
Date: Mon, 21 Sep 2026 01:49:34 -0400
Subject: [PATCH] test(session): catch --help color regressions against the
 live theme

Adds two checks to the shared-palette section, extending the existing
colored list with the functions converted in this branch (config-help,
fish-deps, gi, git-clean, mkrep):

- Every listed function's --help must contain the session's own c_head
  and c_cmd escapes -- not just some escape sequence, which the existing
  presence check already covered but which a wrong-role bug (still some
  color, just not the right one) sails through undetected.
- Every escape sequence found in --help output must be one of
  c_reset/c_head/c_cmd/c_flag/c_arg/c_dim. c_warn/c_err/c_ok/c_accent/
  c_sel/c_hi are legitimate elsewhere but never in --help text; reaching
  for one there is always a bug, which is exactly what logs and
  smart_exit did (static c_accent green for the command name).

Verified against the pre-fix smart_exit.fish (58d5cf3~1): both checks
fail on it -- missing c_head on "Options:", and a disallowed \e[32m for
the command name -- confirming this isn't a tautological pass.
---
 tests/test-session.fish | 53 +++++++++++++++++++++++++++++++++++++----
 1 file changed, 49 insertions(+), 4 deletions(-)

diff --git a/tests/test-session.fish b/tests/test-session.fish
index 1fcf784..96b59aa 100644
--- a/tests/test-session.fish
+++ b/tests/test-session.fish
@@ -145,10 +145,10 @@ check "palette roles all defined, non-empty, and scoped to the caller" true (tes
 # which is not installed in CI, so its colour path is unreachable here.
 # tests/palette-bytes.fish stubs aichat and does cover it.
 function test_functions_keep_their_palette
-    set -l colored agents-init agents-vault auto-pull config-settings \
-        config-update detach dng2avif dockup edit jobrunner kitty-logging \
-        logs mkcd open-url p pkg play-media rand_string replay repo-open \
-        scrub smart_exit spark y
+    set -l colored agents-init agents-vault auto-pull config-help \
+        config-settings config-update detach dng2avif dockup edit fish-deps \
+        gi git-clean jobrunner kitty-logging logs mkcd mkrep open-url p pkg \
+        play-media rand_string replay repo-open scrub smart_exit spark y
     set -l uncolored
     for fn in $colored
         functions -q $fn; or continue
@@ -164,6 +164,51 @@ function test_functions_keep_their_palette
 end
 check "colored --help output keeps its escape sequences" true (test_functions_keep_their_palette; and echo true; or echo false)
 
+# The presence check above only catches a --help block that lost ALL of its
+# colour. It would not have caught the actual regressions found by hand in
+# config-help/logs/smart_exit: a heading or command name left in the PREVIOUS
+# static colour (or another role's colour) instead of the current dynamic
+# one, because *some* escape sequence is still present -- just the wrong
+# one. These two checks compare against the palette's OWN roles, computed in
+# this same session, so they track the theme instead of a hand-copied value.
+#
+# c_warn/c_err/c_ok/c_accent/c_sel/c_hi are deliberately excluded from
+# "allowed": those are the STATIC roles (see __fish_palette's own NOTES) and
+# are legitimate elsewhere, but a --help block that reaches for one of them
+# is always a mistake -- logs and smart_exit both did this, coloring their
+# own command name with the static c_accent green instead of the
+# theme-derived c_cmd. Reusing $colored from the test above -- same
+# functions, same "not installed" skip.
+function test_help_colors_are_theme_derived
+    __fish_palette
+    set -l allowed $c_reset $c_head $c_cmd $c_flag $c_arg $c_dim
+    set -l colored agents-init agents-vault auto-pull config-help \
+        config-settings config-update detach dng2avif dockup edit fish-deps \
+        gi git-clean jobrunner kitty-logging logs mkcd mkrep open-url p pkg \
+        play-media rand_string replay repo-open scrub smart_exit spark y
+    set -l failed 0
+    for fn in $colored
+        functions -q $fn; or continue
+        set -l out ($fn --help 2>&1 | string collect)
+        set -l missing_head 0
+        set -l missing_cmd 0
+        string match -q "*$c_head*" -- $out; or set missing_head 1
+        string match -q "*$c_cmd*" -- $out; or set missing_cmd 1
+        if test $missing_head -eq 1; or test $missing_cmd -eq 1
+            echo "    $fn: missing"(test $missing_head -eq 1; and echo " a heading (c_head)")(test $missing_cmd -eq 1; and echo " its own command color (c_cmd)")
+            set failed 1
+        end
+        for code in (string match -ar -- '\e\[[0-9;]*m' -- $out | sort -u)
+            if not contains -- $code $allowed
+                echo "    $fn: --help uses a color outside the head/cmd/flag/arg/dim/reset roles"
+                set failed 1
+            end
+        end
+    end
+    return $failed
+end
+check "help output uses only the dynamic head/cmd/flag/arg roles" true (test_help_colors_are_theme_derived; and echo true; or echo false)
+
 section "session: config-settings state dump"
 
 # The curses TUI is a child process: it can neither read the session's global