From 63288d9fd642ea081e759086c5a7c792026d02fa Mon Sep 17 00:00:00 2001
From: Rootiest <chris@rootiest.com>
Date: Wed, 16 Sep 2026 19:06:43 -0400
Subject: [PATCH] fix(agents-init): only scaffold inside a git repository

Resolving the root to (pwd) meant running an agent CLI anywhere created an
AGENTS/ git repo, an AGENTS.md, two root symlinks, and a docs/ tree in that
directory. Scaffolding now requires a git repo or a pre-existing agent file
(AGENTS.md, CLAUDE.md, or AGENTS/); elsewhere it is a no-op.
---
 functions/agents-init.fish   | 20 ++++++++++++++++++--
 tests/test-agents-vault.fish | 22 ++++++++++++++++++++++
 2 files changed, 40 insertions(+), 2 deletions(-)

diff --git a/functions/agents-init.fish b/functions/agents-init.fish
index ca36e19..539e4ef 100644
--- a/functions/agents-init.fish
+++ b/functions/agents-init.fish
@@ -17,6 +17,11 @@
 #   agent-related files into it, and replaces them with symlinks so the outer
 #   project never tracks agent files directly.
 #
+#   Scaffolding runs only inside a git repository, or in a directory that
+#   already has an AGENTS.md, CLAUDE.md, or AGENTS/. Elsewhere it is a
+#   no-op, so running an agent CLI in an arbitrary directory does not
+#   create a repository there.
+#
 #   File layout after setup:
 #     AGENTS/AGENTS.md          canonical agent spec (real file)
 #     AGENTS/CLAUDE.md          real file (if CLAUDE.md existed separately)
@@ -127,9 +132,20 @@ function agents-init --description 'scaffold AGENTS/ sub-repo with agent spec fi
     end
     # --verbose is explicit default; no-op but accepted for completeness
 
-    # Resolve target root: git root if available, otherwise cwd
+    # Only scaffold inside a git repository, or where an agent file already
+    # exists. Falling back to (pwd) meant `claude --version` in any
+    # directory created an AGENTS/ repo, two root symlinks, and a docs/
+    # tree there.
     set -l root (git rev-parse --show-toplevel 2>/dev/null)
-    test -z "$root"; and set root (pwd)
+    if test -z "$root"
+        if test -e (pwd)/AGENTS.md -o -e (pwd)/CLAUDE.md -o -d (pwd)/AGENTS
+            set root (pwd)
+        else
+            test $verbose -eq 1
+            and echo "$c_dim→ Not a git repository; skipping AGENTS/ scaffolding$c_reset"
+            return 0
+        end
+    end
 
     set -l agents_dir "$root/AGENTS"
     set -l plugins_dir "$agents_dir/plugins"
diff --git a/tests/test-agents-vault.fish b/tests/test-agents-vault.fish
index 9a92f0b..823d458 100644
--- a/tests/test-agents-vault.fish
+++ b/tests/test-agents-vault.fish
@@ -2053,6 +2053,28 @@ check "agents-init: a rejected commit returns non-zero" 1 "$ibrc"
 check "agents-init: a rejected commit says nothing was recorded" true (string match -q '*nothing recorded*' -- (cat $ierr); and echo true; or echo false)
 check "agents-init: a rejected commit really recorded nothing" $ibhead (git -C $ip/AGENTS rev-list --count HEAD)
 
+#   ─────────────────────── scaffolding guard ──────────────────────────────
+# Resolving the root to (pwd) meant running an agent CLI in any directory
+# created an AGENTS/ repo, root symlinks and a docs/ tree there.
+echo ""
+echo "== agents-init scaffolding guard =="
+
+set -l plain (mktemp -d)
+set -ga TMPDIRS $plain
+pushd $plain >/dev/null
+agents-init --silent 2>/dev/null
+popd >/dev/null
+check "no scaffold in a non-git dir" false (test -e $plain/AGENTS; and echo true; or echo false)
+
+# A pre-existing agent file still opts the directory in.
+set -l plainagents (mktemp -d)
+set -ga TMPDIRS $plainagents
+touch $plainagents/AGENTS.md
+pushd $plainagents >/dev/null
+agents-init --silent 2>/dev/null
+popd >/dev/null
+check "an existing AGENTS.md still scaffolds" true (test -d $plainagents/AGENTS; and echo true; or echo false)
+
 #   ──────────────────────── hermeticity assertion ────────────────────────
 # The whole suite must never have touched the real global agent state. The
 # failure this guards is specific: a global-memory sync with no test