From a7510cc8ea6c62f5303e39eab0818f859cddc11a Mon Sep 17 00:00:00 2001
From: rootiest <chris@rootiest.com>
Date: Mon, 18 May 2026 23:46:34 -0400
Subject: [PATCH] fix(fish-deps): filter fish-* tags only; fix starship sh -s
 flag

git tag --list 'fish-*' replaces for-each-ref so old pre-Rust tags like
pre_whitespace_fix (which have no Cargo.toml) are never selected.

starship update: sh -s -- --yes correctly passes --yes to the piped
install script instead of treating it as a filename for sh to open.
---
 functions/_fish_deps_install.fish | 2 +-
 functions/_fish_deps_update.fish  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/functions/_fish_deps_install.fish b/functions/_fish_deps_install.fish
index 618e74c..03db4e3 100644
--- a/functions/_fish_deps_install.fish
+++ b/functions/_fish_deps_install.fish
@@ -228,7 +228,7 @@ function _fish_deps_install
                     set -l _build_ok 0
                     git clone https://github.com/fish-shell/fish-shell "$_tmpdir"
                     and begin
-                        set -l _tag (git -C "$_tmpdir" for-each-ref refs/tags/ --format '%(refname:short)' --sort=version:refname | tail -1)
+                        set -l _tag (git -C "$_tmpdir" tag --list 'fish-*' --sort=version:refname | tail -1)
                         test -n "$_tag"; and git -C "$_tmpdir" checkout "$_tag"
                         true
                     end
diff --git a/functions/_fish_deps_update.fish b/functions/_fish_deps_update.fish
index ad8e39b..1ae31f7 100644
--- a/functions/_fish_deps_update.fish
+++ b/functions/_fish_deps_update.fish
@@ -110,7 +110,7 @@ function _fish_deps_update
                 set -l _build_ok 0
                 git clone https://github.com/fish-shell/fish-shell "$_tmpdir"
                 and begin
-                    set -l _tag (git -C "$_tmpdir" for-each-ref refs/tags/ --format '%(refname:short)' --sort=version:refname | tail -1)
+                    set -l _tag (git -C "$_tmpdir" tag --list 'fish-*' --sort=version:refname | tail -1)
                     test -n "$_tag"; and git -C "$_tmpdir" checkout "$_tag"
                     true
                 end
@@ -145,7 +145,7 @@ function _fish_deps_update
         if test "$special" = curl-installer
             if test "$bin" = starship
                 echo "Updating $bin..."
-                curl -sS https://starship.rs/install.sh | sh -- --yes
+                curl -sS https://starship.rs/install.sh | sh -s -- --yes
                 set updated_any 1
             end
             set i (math $i + 1)