From d3028d770389f314c00b7fece724a8980490a117 Mon Sep 17 00:00:00 2001
From: Rootiest <chris@rootiest.com>
Date: Mon, 7 Sep 2026 19:59:23 -0400
Subject: [PATCH] refactor(tests): extract the shared assertion core into
 tests/lib.fish

check/section/report and the counters move out of the vault suite
unchanged. report also writes its counts to $FISH_CONFIG_TEST_COUNTS so a
driver can aggregate without parsing stdout, and ends on an explicit
boolean per AGENTS.md item 5.

All 317 vault assertions and every fixture helper are untouched.
---
 tests/lib.fish               | 62 ++++++++++++++++++++++++++++++++++++
 tests/test-agents-vault.fish | 21 ++----------
 2 files changed, 64 insertions(+), 19 deletions(-)
 create mode 100644 tests/lib.fish

diff --git a/tests/lib.fish b/tests/lib.fish
new file mode 100644
index 0000000..2edfc91
--- /dev/null
+++ b/tests/lib.fish
@@ -0,0 +1,62 @@
+#!/usr/bin/env fish
+# Copyright (C) 2026 Rootiest
+# SPDX-License-Identifier: AGPL-3.0-or-later
+#
+# Shared assertion and reporting core for tests/test-*.fish.
+#
+# One assertion: `check <label> <want> <got>`, string equality. Status
+# assertions use the two-line form, which is the point -- it can say "I
+# expected exactly 1", where a pass/fail predicate can only say "non-zero":
+#
+#     __fish_config_op_cascade __probe_cat
+#     check "all unset -> enabled" 0 $status
+#
+# That distinction matters here: __fish_variable_check returns four distinct
+# codes (0 truthy, 1 falsy, 2 unset/empty, 3 unrecognized) and the cascade's
+# behavior depends on telling 2 and 3 apart from 1.
+#
+# Boolean assertions use the idiom the vault suite already uses throughout:
+#
+#     check "label" true (some-test; and echo true; or echo false)
+
+set -g TESTS_RUN 0
+set -g TESTS_FAILED 0
+
+# The driver always sets this; the fallback is for running a suite by hand.
+if set -q FISH_CONFIG_TEST_ROOT
+    set -g repo_root $FISH_CONFIG_TEST_ROOT
+else
+    set -g repo_root (realpath (dirname (status filename))/..)
+end
+
+function section
+    echo ""
+    echo "== $argv[1] =="
+end
+
+function check --argument-names label want got
+    set -g TESTS_RUN (math $TESTS_RUN + 1)
+    if test "$want" = "$got"
+        echo "  PASS  $label"
+    else
+        echo "  FAIL  $label"
+        echo "        want: $want"
+        echo "        got:  $got"
+        set -g TESTS_FAILED (math $TESTS_FAILED + 1)
+    end
+end
+
+function report
+    echo ""
+    echo (math $TESTS_RUN - $TESTS_FAILED)"/$TESTS_RUN passed"
+    if set -q FISH_CONFIG_TEST_COUNTS
+        echo "$TESTS_RUN $TESTS_FAILED" >>$FISH_CONFIG_TEST_COUNTS
+    end
+    # Explicit terminal status, never a trailing `if` (AGENTS.md item 5).
+    # This is form, not a bug fix: fish clamps `exit`/`return` to 255 rather
+    # than wrapping mod 256, so `exit $TESTS_FAILED` could not have produced
+    # a false green. Verified: `fish -c 'exit 256'` -> 255, while
+    # `sh -c 'exit 256'` -> 0. A boolean is still the right shape -- it
+    # composes with `and`/`or`, which a raw count does not.
+    test $TESTS_FAILED -eq 0
+end
diff --git a/tests/test-agents-vault.fish b/tests/test-agents-vault.fish
index 0d85e6d..5628e1f 100644
--- a/tests/test-agents-vault.fish
+++ b/tests/test-agents-vault.fish
@@ -8,12 +8,9 @@
 #
 # Usage: fish tests/test-agents-vault.fish
 
-set -l here (realpath (dirname (status filename)))
-set -g repo_root (realpath $here/..)
+source (realpath (dirname (status filename)))/lib.fish
 set -p fish_function_path $repo_root/functions
 
-set -g TESTS_RUN 0
-set -g TESTS_FAILED 0
 set -g TMPDIRS
 
 # The suite is hermetic against $HOME and ~/.claude, but it was not
@@ -50,18 +47,6 @@ set -gx GIT_CONFIG_VALUE_0 false
 set -gx GIT_CONFIG_KEY_1 init.defaultBranch
 set -gx GIT_CONFIG_VALUE_1 main
 
-function check --argument-names label want got
-    set -g TESTS_RUN (math $TESTS_RUN + 1)
-    if test "$want" = "$got"
-        echo "  PASS  $label"
-    else
-        echo "  FAIL  $label"
-        echo "        want: $want"
-        echo "        got:  $got"
-        set -g TESTS_FAILED (math $TESTS_FAILED + 1)
-    end
-end
-
 # Failure injection that survives uid 0.
 #
 # These fixtures used to force a failure with `chmod 500` on a parent
@@ -1995,6 +1980,4 @@ set -e __fish_agent_vault_claude_home
 set -e __fish_agent_vault_agy_root
 
 cleanup
-echo ""
-echo (math $TESTS_RUN - $TESTS_FAILED)"/$TESTS_RUN passed"
-exit $TESTS_FAILED
+report