Merge pull request 'fix(keybinds): guard bindings on required binaries and fix fzf compat' (#16) from fix/fzf-keybind-guards into main

Reviewed-on: #16

conf.d/fzf.fish

@@ -9,7 +9,8 @@ end
 # This variable is global so that it can be referenced by fzf_configure_bindings and in tests
 set --global _fzf_search_vars_command '_fzf_search_variables (set --show | psub) (set --names | psub)'
 
-# Install the default bindings, which are mnemonic and minimally conflict with fish's preset bindings
+# Install the default bindings only if fzf is available
+type -q fzf || exit
 fzf_configure_bindings
 
 # Doesn't erase autoloaded _fzf_* functions because they are not easily accessible once key bindings are erased

conf.d/key_bindings.fish

@@ -52,7 +52,7 @@ function fish_user_key_bindings
     bind ctrl-g __insert_previous_path_head
     bind ctrl-f __interactive_history_sub
     bind ctrl-alt-u _replace_command_token
-    bind ctrl-alt-= _qalc_eval
+    type -q qalc && bind ctrl-alt-= _qalc_eval
     bind ctrl-enter _smart_execute
 
     # Set bindings for all Vi modes:
@@ -61,7 +61,7 @@ function fish_user_key_bindings
         bind --mode $mode ctrl-g __insert_previous_path_head
         bind --mode $mode ctrl-f __interactive_history_sub
         bind --mode $mode ctrl-alt-u _replace_command_token
-        bind --mode $mode ctrl-alt-= _qalc_eval
+        type -q qalc && bind --mode $mode ctrl-alt-= _qalc_eval
         bind --mode $mode ctrl-enter _smart_execute
     end
 end

functions/_qalc_eval.fish

@@ -3,6 +3,8 @@
 
 # Returns the result of a qalc calculation
 function _qalc_eval
+    type -q qalc || return 1
+
     # Get the current command line buffer
     set -l cmd (commandline)
 

functions/_smart_execute.fish

@@ -15,8 +15,8 @@ function _smart_execute --description 'Execute different functions based on the
     # 2. Dispatch based on buffer content
     switch "$cmd"
         case '*='
-            # If it ends in =, run qalc
+            # If it ends in =, run qalc; fall back to normal execute if qalc is absent
-            _qalc_eval
+            _qalc_eval; or commandline -f execute
 
 #       case 'g *'
 #           # EXAMPLE FUTURE EXTENSION

integrations/fzf.fish

@@ -31,6 +31,14 @@ function fzf_key_bindings
     return 1
   end
 
+  # bg-transform runs the preview toggle in a background thread (non-blocking).
+  # It was added after fzf 0.60; fall back to the synchronous transform on older builds.
+  set -l _fzf_ver (fzf --version | string match -r '^(\d+)\.(\d+)')
+  set -l _fzf_transform_action transform
+  if test -n "$_fzf_ver[3]"; and test "$_fzf_ver[3]" -ge 62
+    set _fzf_transform_action bg-transform
+  end
+
 #----BEGIN INCLUDE common.fish
 # NOTE: Do not directly edit this section, which is copied from "common.fish".
 # To modify it, one can edit "common.fish" and run "./update.sh" to apply
@@ -177,17 +185,25 @@ function fzf_key_bindings
     commandline -f repaint
   end
 
-  function fzf-history-widget -d "Show command history"
+  function fzf-history-widget --inherit-variable _fzf_transform_action -d "Show command history"
     set -l -- command_line (commandline)
     set -l -- current_line (commandline -L)
     set -l -- total_lines (count $command_line)
     set -l -- fzf_query (string escape -- $command_line[$current_line])
 
+    # These options require newer fzf; omit them on older builds
+    set -l _fzf_preview_wrap_sign ''
+    set -l _fzf_toggle_raw ''
+    if test "$_fzf_transform_action" = bg-transform
+      set _fzf_preview_wrap_sign ' --preview-wrap-sign="↳ "'
+      set _fzf_toggle_raw ,alt-r:toggle-raw
+    end
+
     set -lx -- FZF_DEFAULT_OPTS (__fzf_defaults '' \
-      '--nth=2..,.. --scheme=history --multi --no-multi-line --no-wrap --wrap-sign="\t\t\t↳ " --preview-wrap-sign="↳ "' \
+      '--nth=2..,.. --scheme=history --multi --no-multi-line --no-wrap --wrap-sign="\t\t\t↳ "'$_fzf_preview_wrap_sign \
       '--bind=\'shift-delete:execute-silent(for i in (string split0 -- <{+f}); eval builtin history delete --exact --case-sensitive -- (string escape -n -- $i | string replace -r "^\d*\\\\\\t" ""); end)+reload(eval $FZF_DEFAULT_COMMAND)\'' \
       '--bind="alt-enter:become(string join0 -- (string collect -- {+2..} | fish_indent -i))"' \
-      "--bind=ctrl-r:toggle-sort,alt-r:toggle-raw --highlight-line $FZF_CTRL_R_OPTS" \
+      "--bind=ctrl-r:toggle-sort$_fzf_toggle_raw --highlight-line $FZF_CTRL_R_OPTS" \
       '--accept-nth=2.. --delimiter="\t" --tabstop=4 --read0 --print0 --with-shell='(status fish-path)\\ -c)
 
     # Add dynamic preview options if preview command isn't already set by user
@@ -205,10 +221,13 @@ function fzf_key_bindings
       end
 
       # Prepend the options to allow user customizations
+      # wrap-word requires the same newer fzf as bg-transform; fall back to plain wrap
+      set -l _fzf_wrap_opt wrap
+      test "$_fzf_transform_action" = bg-transform; and set _fzf_wrap_opt wrap-word
       set -p -- FZF_DEFAULT_OPTS \
-        '--bind="focus,resize:bg-transform:if test \\"$FZF_COLUMNS\\" -gt 100 -a \\\\( \\"$FZF_SELECT_COUNT\\" -gt 0 -o \\\\( -z \\"$FZF_WRAP\\" -a (string length -- {}) -gt (math $FZF_COLUMNS - 4) \\\\) -o (string collect -- {2..} | fish_indent | count) -gt 1 \\\\); echo show-preview; else echo hide-preview; end"' \
+        '--bind="focus,resize:'$_fzf_transform_action':if test \\"$FZF_COLUMNS\\" -gt 100 -a \\\\( \\"$FZF_SELECT_COUNT\\" -gt 0 -o \\\\( -z \\"$FZF_WRAP\\" -a (string length -- {}) -gt (math $FZF_COLUMNS - 4) \\\\) -o (string collect -- {2..} | fish_indent | count) -gt 1 \\\\); echo show-preview; else echo hide-preview; end"' \
         '--preview="string collect -- (test \\"$FZF_SELECT_COUNT\\" -gt 0; and string collect -- {+2..}) \\"\\n# \\"'$date_cmd' {2..} | fish_indent --ansi"' \
-        '--preview-window="right,50%,wrap-word,follow,info,hidden"'
+        '--preview-window="right,50%,'$_fzf_wrap_opt',follow,info,hidden"'
     end
 
     set -lx FZF_DEFAULT_OPTS_FILE