fix(mv): bring header and completions up to repo conventions #103

2026-08-14T20:02:25Z

rootiest commented

2026-08-14 20:02:25 +00:00

Summary

functions/mv.fish (added in #101) was AI-generated against only a few reference files and had a few small conformance gaps against this repo's actual conventions:

EXIT STATUS silently rendered wrong on the docs site. The >0 row used a single space before its description, but the doc pipeline's table-detection (docs/build-manual.py) requires 2+ spaces to split columns. Below that threshold it falls back to a plain indented block instead of a markdown table — compare how rm.fish's EXIT STATUS renders as a table on its page. Padded to match; verified it now renders identically to rm's.
Stripped trailing whitespace from two DESCRIPTION lines (fish_indent doesn't touch comment content, so this had to be done by hand — the rest of the file already matched fish_indent output exactly).
Added --wraps='mv' so fish inherits real mv's tab-completions, matching this repo's convention for pass-through wrappers (bash --wraps='bash', top --wraps='btop').

No behavioral changes — the function's logic was already correct. I exercised it against the nested-collapse case, plain renames, moving into an existing directory with a different name, and moving into an unrelated directory that happens to share a basename, and all matched expected mv semantics both before and after this change.

docs/verify-manual.py (43/43) and fish_indent both pass clean on the result.

Manual Verification Checklist

fish -n functions/mv.fish reports no syntax errors
python3 docs/verify-manual.py passes
python3 docs/build-manual.py --site and check docs/site/src/content/docs/reference/file-and-directory/mv.md — Exit Status renders as a table
mv themes/themes themes (with a nested duplicate directory) still collapses correctly
mv -<TAB> shows real mv's flag completions

## Summary `functions/mv.fish` (added in #101) was AI-generated against only a few reference files and had a few small conformance gaps against this repo's actual conventions: - **EXIT STATUS silently rendered wrong on the docs site.** The `>0` row used a single space before its description, but the doc pipeline's table-detection (`docs/build-manual.py`) requires 2+ spaces to split columns. Below that threshold it falls back to a plain indented block instead of a markdown table — compare how `rm.fish`'s EXIT STATUS renders as a table on its page. Padded to match; verified it now renders identically to `rm`'s. - Stripped trailing whitespace from two DESCRIPTION lines (`fish_indent` doesn't touch comment content, so this had to be done by hand — the rest of the file already matched `fish_indent` output exactly). - Added `--wraps='mv'` so fish inherits real `mv`'s tab-completions, matching this repo's convention for pass-through wrappers (`bash --wraps='bash'`, `top --wraps='btop'`). No behavioral changes — the function's logic was already correct. I exercised it against the nested-collapse case, plain renames, moving into an existing directory with a different name, and moving into an unrelated directory that happens to share a basename, and all matched expected `mv` semantics both before and after this change. `docs/verify-manual.py` (43/43) and `fish_indent` both pass clean on the result. ## Manual Verification Checklist - [x] `fish -n functions/mv.fish` reports no syntax errors - [x] `python3 docs/verify-manual.py` passes - [x] `python3 docs/build-manual.py --site` and check `docs/site/src/content/docs/reference/file-and-directory/mv.md` — Exit Status renders as a table - [x] `mv themes/themes themes` (with a nested duplicate directory) still collapses correctly - [x] `mv -<TAB>` shows real `mv`'s flag completions

rootiest added 1 commit 2026-08-14 20:02:26 +00:00

fix(mv): bring header and completions up to repo conventions adbcd1d3c0

The EXIT STATUS block used a single space before the ">0" row's
description, which falls below the doc pipeline's 2-space column
threshold and silently degrades the rendered site page from a table
(like rm's) to a plain indented block. Pad it to match. Also strip
trailing whitespace from two DESCRIPTION lines and add --wraps='mv'
so fish inherits real mv's completions, matching the bash/top wrapper
convention.

rootiest merged commit 0e63b4fbb7 into main

2026-08-14 20:02:54 +00:00

rootiest deleted branch fix-mv-header-conformance

2026-08-14 20:02:55 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: rootiest/fish-config#103