rootiest/fish-config
1
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(scrub): restore missing line continuation in aggressive_patterns #115

Merged
rootiest merged 1 commits from fix/scrub-aggressive-patterns-backslash into main 2026-08-22 04:24:31 +00:00
Conversation 0 Commits 1 Files Changed 1
+2 -2
rootiest commented 2026-08-22 04:23:43 +00:00
Owner
Copy Link
Copy Source

Summary

  • A missing trailing \ after the Thumbs.db:encryptable pattern terminated the aggressive_patterns array early
  • The AI-tool patterns (.gemini*, .claude*, .antigravity*, .remember*) were then executed as a bogus command instead of being appended to the array
  • Result: scrub -a never actually purged those patterns, and every scrub invocation printed a spurious Unknown command: '^\.gemini.*' error

Found incidentally while working on the colored --help output task (see the separate feat/colored-help-text PR) — split out here per our new workflow rule of keeping unrelated fixes on their own branch/PR.

Test plan

  • scrub --help no longer throws an error
  • scrub -d -a (dry run + aggressive) lists .claude*/.gemini*/etc. among the aggressive targets found
## Summary - A missing trailing `\` after the `Thumbs.db:encryptable` pattern terminated the `aggressive_patterns` array early - The AI-tool patterns (`.gemini*`, `.claude*`, `.antigravity*`, `.remember*`) were then executed as a bogus command instead of being appended to the array - Result: `scrub -a` never actually purged those patterns, and *every* `scrub` invocation printed a spurious `Unknown command: '^\.gemini.*'` error Found incidentally while working on the colored `--help` output task (see the separate `feat/colored-help-text` PR) — split out here per our new workflow rule of keeping unrelated fixes on their own branch/PR. ## Test plan - [x] `scrub --help` no longer throws an error - [x] `scrub -d -a` (dry run + aggressive) lists `.claude*`/`.gemini*`/etc. among the aggressive targets found
rootiest added 1 commit 2026-08-22 04:23:43 +00:00
fix(scrub): restore missing line continuation in aggressive_patterns 9e74cb8f0a 
A missing trailing backslash after the Thumbs.db:encryptable pattern
terminated the `set -l aggressive_patterns` array early. The AI-tool
patterns (.gemini*, .claude*, .antigravity*, .remember*) were then
executed as a bogus command instead of being appended to the array,
so scrub -a never actually purged them, and every scrub invocation
printed a spurious "Unknown command" error.
rootiest merged commit b1a0c6c488 into main 2026-08-22 04:24:31 +00:00
rootiest deleted branch fix/scrub-aggressive-patterns-backslash 2026-08-22 04:24:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
rootiest (Rootiest)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rootiest/fish-config#115