style(tests): satisfy fish_indent in the agents-vault suite #154

2026-09-16T23:15:47Z

rootiest commented

2026-09-16 23:15:47 +00:00

Fixes the red CI on main from run #947, introduced by #153.

The test job reported TOTAL: 753/753 assertions passed and still exited 1. The failure was in Phase 1 of tests/run-tests.fish, hundreds of lines above the summary:

  FAIL (indent) tests/test-agents-vault.fish
248/249 files passed indent check

The gitignore-anchoring check added in #153 quoted two arguments that fish_indent strips:

-_agents_init_ensure_gitignore $ng "test" "AGENTS/" >/dev/null
+_agents_init_ensure_gitignore $ng test AGENTS/ >/dev/null

That one line is the whole diff — fish_indent -w produced no other change.

The verification on #153 read the suite's tail (TOTAL:) rather than the driver's exit status, which is exactly the signal that was wrong. Checked properly this time:

fish tests/run-tests.fish
EXIT=0
249/249 files passed syntax check
249/249 files passed indent check
TOTAL: 753/753 assertions passed

Fixes the red CI on `main` from run [#947](https://git.rootiest.dev/rootiest/fish-config/actions/runs/947), introduced by #153. The `test` job reported `TOTAL: 753/753 assertions passed` and still exited 1. The failure was in Phase 1 of `tests/run-tests.fish`, hundreds of lines above the summary: ``` FAIL (indent) tests/test-agents-vault.fish 248/249 files passed indent check ``` The gitignore-anchoring check added in #153 quoted two arguments that `fish_indent` strips: ```fish -_agents_init_ensure_gitignore $ng "test" "AGENTS/" >/dev/null +_agents_init_ensure_gitignore $ng test AGENTS/ >/dev/null ``` That one line is the whole diff — `fish_indent -w` produced no other change. The verification on #153 read the suite's tail (`TOTAL:`) rather than the driver's exit status, which is exactly the signal that was wrong. Checked properly this time: ``` fish tests/run-tests.fish EXIT=0 249/249 files passed syntax check 249/249 files passed indent check TOTAL: 753/753 assertions passed ```

rootiest added the Kind/Bug Area/Tests labels 2026-09-16 23:15:47 +00:00

rootiest added 1 commit 2026-09-16 23:15:47 +00:00

style(tests): satisfy fish_indent in the agents-vault suite fb62005140

The gitignore-anchoring check quoted arguments fish_indent removes, so
run-tests.fish failed its indent lint and exited 1 on main even though all
753 assertions passed.

rootiest referenced this pull request

2026-09-16 23:19:24 +00:00

fix(agents-init): require a git repo to scaffold, and anchor the .gitignore fallback match #153

rootiest merged commit f901ec460f into main

2026-09-16 23:19:42 +00:00

rootiest deleted branch fix/agents-vault-test-indent

2026-09-16 23:19:43 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: rootiest/fish-config#154