rootiest/fish-config
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(docs): update verify-manual test for section renumber #84

Merged
rootiest merged 1 commits from fix/troubleshooting-ci-verification into main 2026-07-27 04:04:50 +00:00
Conversation 0 Commits 1 Files Changed 2
+236 -4
rootiest commented 2026-07-27 04:04:27 +00:00
Owner
Copy Link
Copy Source

Summary

Fixes the CI verification failure introduced by the troubleshooting section merge (PR #83).

Root cause

Two issues from the Section 11↔12 renumber:

  1. verify-manual.py hardcoded 11-viewing-this-manual.mdx in test_site_promotes_pages_with_asides_or_filetrees_to_mdx — updated to 12-viewing-this-manual.mdx
  2. docs/fish-config.md (the generated concat) was stale — regenerated to include the new troubleshooting section and updated section numbers

Verification

  • python3 docs/verify-manual.py → 43/43 passed (0 failures, 8 pre-existing WARNs)

Verification Checklist

  • CI verify-manual.py passes with 0 failures
  • help config troubleshooting still opens the new section
  • Doc site builds successfully
## Summary Fixes the CI verification failure introduced by the troubleshooting section merge (PR #83). ### Root cause Two issues from the Section 11↔12 renumber: 1. `verify-manual.py` hardcoded `11-viewing-this-manual.mdx` in `test_site_promotes_pages_with_asides_or_filetrees_to_mdx` — updated to `12-viewing-this-manual.mdx` 2. `docs/fish-config.md` (the generated concat) was stale — regenerated to include the new troubleshooting section and updated section numbers ### Verification - `python3 docs/verify-manual.py` → **43/43 passed** (0 failures, 8 pre-existing WARNs) ## Verification Checklist - [ ] CI `verify-manual.py` passes with 0 failures - [ ] `help config troubleshooting` still opens the new section - [ ] Doc site builds successfully
rootiest added 1 commit 2026-07-27 04:04:28 +00:00
fix(docs): update verify-manual test for section renumber and regenerate concat 911e656e5e 
The troubleshooting section renumbered Viewing This Manual from 11 to
12, but verify-manual.py still hardcoded the old filename
(11-viewing-this-manual.mdx) in the site promotion test. Update both
references to 12-viewing-this-manual.mdx.

Also regenerate docs/fish-config.md so the concat roundtrip test passes
with the new section ordering.
rootiest merged commit 49e487ac3b into main 2026-07-27 04:04:50 +00:00
rootiest deleted branch fix/troubleshooting-ci-verification 2026-07-27 04:04:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rootiest (Rootiest)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rootiest/fish-config#84
Delete Branch "fix/troubleshooting-ci-verification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?