rootiest/qmk_firmware
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(k17): add tap-chord dance to K17 Max #13

Merged
rootiest merged 2 commits from feat/k17/tap-chords into main 2026-04-11 05:01:28 +00:00
Conversation 0 Commits 2 Files Changed 1
+12 -2
rootiest commented 2026-04-11 04:52:12 +00:00
Owner
Copy Link
Copy Source

Adds a tap-dance key to the Keychron K17 Max that sends VS Code chord shortcuts:

  • Single tap: Ctrl+K Ctrl+C (add line comment)
  • Double tap: Ctrl+K Ctrl+D (format document)

Uses ACTION_TAP_DANCE_FN with SEND_STRING — the correct approach for sending key sequences from tap-dance. Also removes leftover dead custom keycode stubs from an earlier failed implementation attempt.

Adds a tap-dance key to the Keychron K17 Max that sends VS Code chord shortcuts: - Single tap: `Ctrl+K Ctrl+C` (add line comment) - Double tap: `Ctrl+K Ctrl+D` (format document) Uses `ACTION_TAP_DANCE_FN` with `SEND_STRING` — the correct approach for sending key sequences from tap-dance. Also removes leftover dead custom keycode stubs from an earlier failed implementation attempt.
rootiest added 2 commits 2026-04-11 04:52:13 +00:00
feat(k17): add tap-chords to keychron k17_max 6d6eee5571
fix(k17): remove dead custom keycode stubs from tap-chord dance 5f9121c0d2 
CK_CTRL_K_C and CK_CTRL_K_D were leftover from an earlier failed
attempt using ACTION_TAP_DANCE_DOUBLE with custom keycodes. Now that
TD_CHORDS uses ACTION_TAP_DANCE_FN with SEND_STRING, they are unused.
rootiest changed target branch from feat/raw-hid to main 2026-04-11 05:01:06 +00:00
rootiest merged commit f9972b2fee into main 2026-04-11 05:01:28 +00:00
rootiest deleted branch feat/k17/tap-chords 2026-04-11 05:01:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 documentation
Scope affects only documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
rootiest (Rootiest)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rootiest/qmk_firmware#13
Delete Branch "feat/k17/tap-chords"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?