feat(help): standardize colored --help output across functions #116

2026-08-22T04:23:54Z

rootiest commented

2026-08-22 04:23:54 +00:00

Summary

play-media --help was missing the color/style standard used by the rest of the functions — fixed, plus a scan of every other function's --help (or usage-on-error) output for the same gap
Added the standard c_head/c_cmd/c_flag/c_dim/c_arg color scheme to 13 more functions that lacked it or used an ad hoc scheme: bkg, detach, replay, p, y, spark, wake-lock, open-url, repo-open, dng2avif, dockup, fish-deps (__fish_deps_help), scrub
Tweaked the standard itself, applied everywhere it's used (old and new):
- c_cmd now uses plain set_color --bold instead of --bold white, so the command name adapts to the terminal's foreground color instead of forcing white text that washes out on light-background themes
- jobrunner's reset variable renamed from c_rst to c_reset to match every other function

Not included: the missing-backslash bug in scrub.fish's aggressive_patterns array — that's unrelated to this task and split out into #115.

Test plan

All 25 touched functions source cleanly with no syntax errors
--help output visually verified for every changed function (color renders correctly, no stray escape codes)
Spot-check a few in your own terminal theme (this PR includes the light-background contrast fix for c_cmd, worth confirming it looks right)

## Summary - `play-media --help` was missing the color/style standard used by the rest of the functions — fixed, plus a scan of every other function's `--help` (or usage-on-error) output for the same gap - Added the standard `c_head`/`c_cmd`/`c_flag`/`c_dim`/`c_arg` color scheme to 13 more functions that lacked it or used an ad hoc scheme: `bkg`, `detach`, `replay`, `p`, `y`, `spark`, `wake-lock`, `open-url`, `repo-open`, `dng2avif`, `dockup`, `fish-deps` (`__fish_deps_help`), `scrub` - Tweaked the standard itself, applied everywhere it's used (old and new): - `c_cmd` now uses plain `set_color --bold` instead of `--bold white`, so the command name adapts to the terminal's foreground color instead of forcing white text that washes out on light-background themes - `jobrunner`'s reset variable renamed from `c_rst` to `c_reset` to match every other function Not included: the missing-backslash bug in `scrub.fish`'s `aggressive_patterns` array — that's unrelated to this task and split out into #115. ## Test plan - [x] All 25 touched functions source cleanly with no syntax errors - [x] `--help` output visually verified for every changed function (color renders correctly, no stray escape codes) - [x] Spot-check a few in your own terminal theme (this PR includes the light-background contrast fix for `c_cmd`, worth confirming it looks right)

rootiest added 1 commit 2026-08-22 04:23:54 +00:00

feat(help): standardize colored --help output across functions 500dd8a735

Add the established c_head/c_cmd/c_flag/c_dim/c_arg color scheme to
--help (or usage-on-error) output in play-media and 13 other functions
that lacked it or used an ad hoc scheme: bkg, detach, replay, p, y,
spark, wake-lock, open-url, repo-open, dng2avif, dockup, fish-deps
(__fish_deps_help), and scrub.

Also tweak the standard itself:
- c_cmd now uses plain `set_color --bold` instead of `--bold white`,
  so the command name adapts to the terminal's foreground instead of
  forcing white text that washes out on light-background themes.
  Applied across all functions already using the pattern.
- jobrunner's reset variable renamed from c_rst to c_reset to match
  the naming used everywhere else.

rootiest merged commit 857faebeba into main

2026-08-22 04:24:45 +00:00

rootiest deleted branch feat/colored-help-text

2026-08-22 04:24:45 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: rootiest/fish-config#116