fix(help): full index audit and singular/plural keyword matching #122
No Reviewers
Labels
Clear labels
Area/CI
Area/Completions
Area/Components
Area/Config
Area/Docs
Area/Functions
Area/Integrations
Area/Prompt & Theme
Area/Scripts
Area/Tests
Compat/Breaking
Kind/Bug
Kind/Chore
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Performance
Kind/Refactor
Kind/Security
Kind/Testing
good first issue
help wanted
.github/workflows and repository automation
completions/ - tab-completion scripts
The opinionated-component system (C1-C6)
config.fish and conf.d/ - startup and environment
docs/manual/ and the generated manual, man page, and site
functions/ - user-facing functions and helpers
integrations/ - third-party tool wiring
themes/ and prompt appearance
scripts/ - standalone helper scripts
tests/ - the syntax lint and functional suite
Breaking change that won't be backward compatible
Something is not working
Tooling, dependencies, and housekeeping
Documentation changes
Improve existing functionality
New functionality
Makes existing behavior faster or lighter
Restructures code without changing behavior
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Well-scoped and self-contained; a good place to start
Maintainer is looking for someone to pick this up
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
rootiest (Rootiest)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: rootiest/fish-config#122
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
customizationresolved butcustomizationsdidn't, and a number of recent additions were never indexed. Both fixed.Why the plural failed
The fallback matches a keyword contained in a heading, so a plural could never reach a singular heading:
The index lookup was exact-match, so it couldn't cover the gap either without an alias for every word. Now both try the keyword as typed first, then its singular/plural forms — and each variant is tried against every heading before the next is considered, so a loose plural can't beat an exact hit further down the document.
Index audit
284 → 357 entries (+75 added, 2 duplicate keys removed).
play-media,steam-dl,bd-pull,cffetch,ffetch,config-toggle,ld,lD,mv,p,fast-cli,gip4/gip6,dops,rand_string,fzf-update, the prompt functions, and the C1–C6 sub-categories.play-mediaviavideo/audio/mpv/vlc,rand_stringviarandom/password,fast-cliviaspeedtest,ldvialazydocker,gip4/gip6viaipv4/ipv6.key-bindings/keybindings,man-page/manpage) — they normalize identically, so one of each was dead weight.config-togglerepointed to its own heading, which now exists.Deliberately left unindexed: the seven identical
### Sub-categoriesheadings. Any entry pointing at that text always resolves to the first occurrence, so it would be misleading; each parent (C1–C6, Minimal Mode) already has its own keyword. Same reasoning for the duplicate### searchand## Integrationsheadings.Verification
Checked independently against the generated document, not just self-reported:
Resolution spot-checked end to end — singular and plural both directions (
customization/customizations,abbreviation/abbreviations,binding/bindings,plugin/plugins,variable/variables), every new alias above, and a regression pass confirming exact keys still win (functions,path,fzf,prompt,network,sync).tests/run-tests.fish220/220 lint + 10/10,verify-manual.py71/71.Independent of #121 — verified the two merge cleanly.