rootiest/fish-config
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(history): support N-th history index in substitution #2

Merged
rootiest merged 1 commits from feat/hist-sub into main 2026-04-30 22:27:30 +00:00
Conversation 0 Commits 1 Files Changed 1
+12 -2
rootiest commented 2026-04-30 22:25:03 +00:00
Owner
Copy Link
Copy Source

This PR enhances the interactive history substitution function (Ctrl+F) to support an optional history index.

Changes:

  • N-th History Support: You can now use the syntax old/new/index (e.g., foo/bar/3) to perform substitution on the 3rd most recent command in history.
  • Improved Robustness: Added checks to ensure the target command exists before attempting replacement.
  • Sudo Fallback: Maintained existing behavior where an empty command line prepends sudo to the last command.

Verified with local testing.

This PR enhances the interactive history substitution function (`Ctrl+F`) to support an optional history index. ### Changes: - **N-th History Support:** You can now use the syntax `old/new/index` (e.g., `foo/bar/3`) to perform substitution on the 3rd most recent command in history. - **Improved Robustness:** Added checks to ensure the target command exists before attempting replacement. - **Sudo Fallback:** Maintained existing behavior where an empty command line prepends `sudo` to the last command. Verified with local testing.
rootiest added 1 commit 2026-04-30 22:25:04 +00:00
feat(history): add support for Nth history index in substitution ed62c8c100 
Extends the interactive history substitution function to support an
optional third field `old/new/index`.

- Keeps default behavior of targeting the most recent command (index 1).
- Allows targeting a specific history entry by appending a number.
- Validates that the index is a positive integer before attempting retrieval.
- Safely handles cases where the requested history index does not exist.

Example: 'cat/bat/5' now replaces 'cat' with 'bat' in the 5th previous command.
rootiest merged commit 6397e10f2e into main 2026-04-30 22:27:30 +00:00
rootiest deleted branch feat/hist-sub 2026-04-30 22:27:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
rootiest (Rootiest)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rootiest/fish-config#2